Repository navigation
Merge Sort in C#: .NET 10 upgrade and copy-per-call benchmark - #2374
Merged
vladimir-pecanac-main merged 2 commits intoNov 10, 2026
Merged
vladimir-pecanac-main merged 2 commits into
vladimir-pecanac-main merged 2 commits into
Conversation
…ith article Target net10.0 with BenchmarkDotNet 0.15.8, MSTest 4.5.2, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. Move the benchmark into MergeBenchmarks, which copies its input before every call so each invocation sorts unsorted data, and add MemoryDiagnoser. Drop the benchmark-only arrayName parameter so SortArray matches the article. Fix the CollectionAssert argument order and add oracle and edge-case tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades csharp-algorithms/MergeSort to net10.0 with BenchmarkDotNet 0.15.8, MSTest 4.5.2, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. The benchmark moves into a new MergeBenchmarks class that copies its input before every call (the old benchmark sorted the same array in place, so every call after the first measured sorted data) and adds MemoryDiagnoser; Program.cs passes args to BenchmarkRunner. The benchmark-only arrayName parameter is removed so SortArray matches the article, the CollectionAssert argument order is fixed, and two tests compare the sort against Array.Sort on random and edge-case input.